Set fabric label on interview #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting the label on commissioning only, set it during the interview process but only if necessary. This avoids the commissioning process to fail in a incomplete state when setting the label fails. The interview process has more resilience to recover from a failure during the commissioning since we have a retry mechanism in place. This also allows to set the label on devices that are already commissioned. Also (try to) unpair the device in case interviewing fails. This allows user to commission a second time without running into "Trying to add a NOC for a fabric that already exists" errors.
marcelveldt
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the label on commissioning only, set it during the interview process but only if necessary. This avoids the commissioning process to fail in a incomplete state when setting the label fails.
The interview process has more resilience to recover from a failure during the commissioning since we have a retry mechanism in place.
This also allows to set the label on devices that are already commissioned.
Also (try to) unpair the device in case interviewing fails. This allows user to commission a second time without running into "Trying to add a NOC for a fabric that already exists" errors.